search

github / gh-valet

Valet helps facilitate the migration of Azure DevOps, CircleCI, GitLab CI, Jenkins, and Travis CI pipelines to GitHub Actions.
MIT License
510 stars 35 forks source link

Revert parallel console writes #95

Closed luke-engle closed 2 years ago

luke-engle commented 2 years ago

What's changing?

Reverting two changes made that prevent gh-valet from writing stderr and stdout to the console. These changes were causing output hangs for windows machines. We need to pull out these changes until we come up with a more robust solution that works for all machines.

Note - We are still working on a different fix. If there's a quick fix we can make to resolve the Windows issues, then we won't merge these changes.

How's this tested?

Manually ran various commands to ensure they work as expected

Closes #89

github-actions[bot] commented 2 years ago

Unit Test Results

35 tests  ±0   35 :heavy_check_mark: ±0   0s :stopwatch: ±0s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 4d882ce9. ± Comparison against base commit 3fee8af3.