search

github / gh-valet

Valet helps facilitate the migration of Azure DevOps, CircleCI, GitLab CI, Jenkins, and Travis CI pipelines to GitHub Actions.
MIT License
510 stars 35 forks source link

Fix windows hang #96

Closed dwhathaway closed 2 years ago

dwhathaway commented 2 years ago

What's changing?

  1. Relocated if (output) check in ProcessService.cs to be inside the ReadStream() method. This works around a platform difference in how Windows appears to evaluate streams before a process completes.
  2. Update .net to 6.0.402

How's this tested?

Run any gh valet (e.g. gh valet audit) command on Windows, Linux, and MacOS and verify that the command completes and is the same and output is shown on all 3 platforms.

github-actions[bot] commented 2 years ago

Unit Test Results

35 tests  ±0   35 :heavy_check_mark: ±0   0s :stopwatch: ±0s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 7465094b. ± Comparison against base commit 3fee8af3.