search

github / gh-valet

Valet helps facilitate the migration of Azure DevOps, CircleCI, GitLab CI, Jenkins, and Travis CI pipelines to GitHub Actions.
MIT License
510 stars 35 forks source link

Additional docker auth error mesage #97

Closed dwhathaway closed 1 year ago

dwhathaway commented 1 year ago

What's changing?

Adds 1 additional check for docker authentication error messages to apply user-friendly formatting

How's this tested?

On a new, clean installation w/o valid docker credentials cached or providing valid credentials as input, run the gh valet update call and verify that the user is presented with the friendly error message rather than the Error response from daemon error that Docker returns

github-actions[bot] commented 1 year ago

Unit Test Results

38 tests  +1   38 :heavy_check_mark: +1   0s :stopwatch: ±0s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 72a8f938. ± Comparison against base commit 6e80c1ae.

:recycle: This comment has been updated with latest results.

dwhathaway commented 1 year ago

Good call. I'll add a Unit Test for this new case.

dwhathaway commented 1 year ago

Unit test for new case added @luke-engle