github / github-artifact-exporter

A set of packages to make exporting artifacts from GitHub easier
MIT License
279 stars 31 forks source link

Bump electron to 11.5. #65

Closed garnertb closed 2 years ago

garnertb commented 2 years ago

Signed-off-by: Tyler Garner garnertb@github.com

Installing this project on a machine with apple silicon hardware fails since Electron didn't start releasing apple silicon artifacts until Electron 11.

➜  github-artifact-exporter git:(bump-electron) lerna exec npm install   
info cli using local version of lerna
lerna notice cli v3.22.1
lerna info Executing command in 3 packages: "npm install"

up to date, audited 634 packages in 2s

9 packages are looking for funding
  run `npm fund` for details

19 vulnerabilities (12 moderate, 7 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm ERR! code 1
npm ERR! path /Users/tyler/projects/github-artifact-exporter/packages/gui/node_modules/electron
npm ERR! command failed
npm ERR! command sh -c node install.js
npm ERR! HTTPError: Response code 404 (Not Found) for https://github.com/electron/electron/releases/download/v9.4.4/electron-v9.4.4-darwin-arm64.zip

👉🏻 I typically wouldn't include the unrelated package-lock changes from cli/core but looks like those change should have been included before?