search

github / glb-director

GitHub Load Balancer Director and supporting tooling.
Other
2.37k stars 227 forks source link

Modified identifiers according to the naming convention of the C language standard. #122

Open Akshit6828 opened 3 years ago

Akshit6828 commented 3 years ago

Updated glb_director_config.h according to the naming convention of the C language standard.

The following changes mentioned below are proposed in order to uphold the reserve identifier violation of the C language standard:

elfring commented 3 years ago

How do you think about to improve the wording also a bit for the pull request subject?

Akshit6828 commented 3 years ago

Sure @elfring. I'll update the changes and let you know shortly! Thanks for mentioning the changes precisely.

elfring commented 3 years ago

Wording “… naming convention of the C language standard”?

Akshit6828 commented 3 years ago

The commit https://github.com/github/glb-director/pull/122/commits/438eedfbeebbcbbf05c0ef9342c95a8a2163aacb propose changes as explained below to uphold the reserve identifier violation of C language standards

Change 1

Changed pdnet.h with the following changes :

Akshit6828 commented 3 years ago

@elfring please review the commit messages and proposed changes and let me know if any alterations are needed.

elfring commented 3 years ago
Akshit6828 commented 3 years ago

Ok, @elfring. I'll note this feedback and propose changes as described by you as early as possible.

elfring commented 3 years ago

Is your interest growing for any source code search patterns which I mentioned for some software components?

Akshit6828 commented 3 years ago

@elfring sorry to say, but I have less idea regarding how to extend the search of source code as this was my first contribution to any big company's project and that's why I am not aware of practices to extend the search for the source code.

But I am interested in learning new things. I am also reading the resource provided by you. Please correct me if I am not getting your directions.

elfring commented 3 years ago

Do you get any further development ideas from linked information sources?

Akshit6828 commented 3 years ago

Actually @elfring I am a little confused as changes proposed by me in commits changed the identifiers which were reserved words. As this resource says that

"All identifiers that begin with an underscore are always reserved for use as identifiers with file scope in both the ordinary and tag namespaces."

I think that in my proposed changes, the identifiers should begin with an underscore, and the rest of the changes are alright.

Am I correct sir?

Akshit6828 commented 3 years ago

Actually @elfring I am a little confused as changes proposed by me in commits changed the identifiers which were reserved words. As this resource says that

"All identifiers that begin with an underscore are always reserved for use as identifiers with file scope in both the ordinary and tag namespaces."

I think that in my proposed changes, the identifiers should begin with an underscore, and the rest of the changes are alright.

Am I correct sir?

Like:

elfring commented 3 years ago

Please take another look at the rules for the identifier selection. - Your search approach seems to be incomplete so far.

Akshit6828 commented 3 years ago

ok you mean, I need to search more files and identifiers for such issues?

elfring commented 3 years ago

I propose to increase source code analysis accordingly. Did you notice where I reported similar open issues?

Akshit6828 commented 3 years ago

I've gone through the issues and I couldn't see similar issues. It means for increasing source code analysis accordingly, I need to check where the same issue exists.

Sir, please correct me if I am wrong in understanding you.

or

If you don't mind can you point my work precisely that what changes I should do so that I can understand my work better?

elfring commented 3 years ago

… and I couldn't see similar issues.

Do you find the following search approaches interesting?

Akshit6828 commented 3 years ago

Ok sir I'll check these search approaches and change the source code accordingly within few days. Thanks for mentioning them.

elfring commented 3 years ago

:thinking: Would you like to check any source code places besides questionable include guards?

Akshit6828 commented 3 years ago

🤔 Would you like to check any source code places besides questionable include guards?

Hi @elfring. Sorry, I didn't get that. Could you elaborate your question?

elfring commented 3 years ago

Are you familiar with involved software development challenges for include guards?

Akshit6828 commented 3 years ago

No, I am not familiar with it. But I'll read the resource and let you know.