github / glb-director

GitHub Load Balancer Director and supporting tooling.
Other
2.38k stars 229 forks source link

Disable healthchecking on inactive backends. #71

Closed theojulienne closed 4 years ago

theojulienne commented 5 years ago

Currently glb-healthcheck runs health checks on all backends in the forwarding table, even when they are marked inactive and it doesn't make sense to do so.

The forwarding table documentation states:

 * `inactive` - the backend is completely ignored

This PR disables the healthchecking of inactive backends to act the same as the director itself. Health checking these backends will also cause needless reloads of the forwarding table, since inactive ones are filtered out downstream in glb-director-cli as well.