search

github / glb-director

GitHub Load Balancer Director and supporting tooling.
Other
2.38k stars 229 forks source link

Configurabiity of the UDP port # for messaging to statsd #91

Closed ravisinghsfbay closed 4 years ago

ravisinghsfbay commented 4 years ago

Testing done:

  1. Default port # gets setup correctly
  2. Configured value takes effect
  3. Changing the configured value takes effect
  4. Allow admin to choose any UDP port, while being mindful of what is usable.

Note:

  1. Port # will be a string in the Json config configured as below in /etc/glb/director.conf "statsd_port": "12345"
  2. For a config change to take effect, the glb-director will need to be restarted. This is true of all configurable fields in /etc/glb/director.conf
theojulienne commented 4 years ago

Would also be great to add the new field to the config file documentation as part of this PR too, just to keep it in sync 🙇

ravisinghsfbay commented 4 years ago

Thanks for the comments. All have been addressed.