Add Asset and Organization resources

github / hackerone-client

An unofficial wrapper for the HackerOne API

https://rubygems.org/gems/hackerone-client

MIT License

13 stars 3 forks source link

Add Asset and Organization resources #10

Closed jeffgran-dox closed 1 month ago

jeffgran-dox commented 3 months ago

Adds some new resources that are newer in the API.
Updates StructuredScope to have the program id so that it can construct its URLs.

jeffgran-dox commented 2 months ago

@rzhade3 thanks for the review! yes, I'll address your comments and work on adding some specs.

jeffgran-dox commented 2 months ago

@rzhade3 Hi, I believe I have addressed your feedback and added some specs. However, I do not have an easy way to record new VCR fixtures so I just mocked the requests with webmock, pulling the example responses from their API docs. If you'd rather have these use VCR would you mind modifying the code and recording them for me? Thanks

rzhade3 commented 1 month ago

@jeffgran-dox Thanks again for the PR, I've released these changes as version 0.23.0 on Rubygems.

jeffgran-dox commented 1 month ago

@rzhade3 excellent, thank you!