search

github / hackerone-client

An unofficial wrapper for the HackerOne API
https://rubygems.org/gems/hackerone-client
MIT License
13 stars 3 forks source link

Prevent invalid state changes #3

Closed rzhade3 closed 4 months ago

rzhade3 commented 1 year ago

@oreoshake:

The API doesn't like invalid state changes or even state changes to the current state. This can lead to confusing 400 errors.

For the case where you're doing a state change to the current state, we could raise an error in the client.

For the other cases, we'd probably need to map out the valid transitions and check this prior to making a call.

/cc @brentjo @gregose

Transfered from https://github.com/oreoshake/hackerone-client/issues/26

rzhade3 commented 4 months ago

Modeling this would require building out the entire HackerOne state machine on the client, and ensuring that it is always up to date with HackerOne's server implementation. This is an unreasonable burden for this client to bear.

As such, we will not be implementing this feature.