I raised https://github.com/github/hotkey/pull/25 in the hopes of adding support for the meta+shift plane, but this broke shortcuts like data-key=B because it is expecting data-key=Shift+B. The tests were passing because our tests have capitals without shiftKey = true.
This fixes the breakage in 1.3.1 by adding a check to only add the Shift+ modifier if event.key.toUpperCase() !== event.key, allowing for both data-key="Meta+Shift+b"/data-key="B"
I raised https://github.com/github/hotkey/pull/25 in the hopes of adding support for the
meta+shiftplane, but this broke shortcuts likedata-key=Bbecause it is expectingdata-key=Shift+B. The tests were passing because our tests have capitals withoutshiftKey = true.This fixes the breakage in 1.3.1 by adding a check to only add the
Shift+modifier ifevent.key.toUpperCase() !== event.key, allowing for bothdata-key="Meta+Shift+b"/data-key="B"