search

github / hotkey

Trigger an action on an element with a keyboard shortcut.
https://github.github.com/hotkey/
MIT License
3.22k stars 97 forks source link

Key fix #41

Closed jonrohan closed 3 years ago

jonrohan commented 3 years ago

There's a bug when trying to use a symbol like Control+Shift+` as the hotkey. See https://github.com/github/github/pull/175242#discussion_r603640676

Because of this line, ` doesn't have an uppercase value.

I'm trying to fix by checking the KeyboardEvent.code https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code value for "Key" which should be alpha numeric.

jonrohan commented 3 years ago

🎉