github / issue-metrics

Gather metrics on issues/prs/discussions such as time to first response, count of issues opened, closed, etc.

https://github.blog/2023-07-19-metrics-for-issues-pull-requests-and-discussions/

MIT License

406 stars 53 forks source link

fix: Negative time duration for labels applied after issue close; Inflated metric numbers for unlabeled labels on open issues #287

Closed smstone closed 4 months ago

smstone commented 4 months ago

Pull Request

I came across two additional issues in label time durations:

Negative time durations metrics for issues where the label was applied after issue close.
Inflated time durations for unlabeled issues where the issue is still open (I think I introduced the issue in https://github.com/github/issue-metrics/pull/283)

Proposed Changes

Readiness Checklist

Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[x] run make lint and fix any issues that you have introduced
[x] run make test and ensure you have test coverage for the lines you are introducing

Reviewer

[x] Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

jmeridth commented 4 months ago

@smstone another great catch. Will look soon. Thank you for the contribution.