github / issue-metrics

Gather metrics on issues/prs/discussions such as time to first response, count of issues opened, closed, etc.

https://github.blog/2023-07-19-metrics-for-issues-pull-requests-and-discussions/

MIT License

406 stars 53 forks source link

fix: issue accessing repo when not provided in query #291

Closed jmeridth closed 4 months ago

jmeridth commented 4 months ago

Fixes #290

Pull Request

Proposed Changes

[x] handle trying to access repository from dictionary when not present (use default of empty string)
[x] add test to ensure we cover this scenario
[x] renamed other test to match not testing repository present
[x] handle issue where total_time_to_close variable was being access before possibly being declared
- caught by linting locally (E0606: Possibly using variable 'total_time_to_close' before assignment (possibly-used-before-assignment))

Readiness Checklist

Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[x] run make lint and fix any issues that you have introduced
[x] run make test and ensure you have test coverage for the lines you are introducing

Reviewer

[x] Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking