Mezzle
commented
10 years ago To clarify:
- 2 branches, a + b.
- Average "build time" is 20 minutes.
- User 1 pushes branch a, build is triggered, gets marked as "started" on github
- 2 minutes later, user 2 pushes branch b. This gets queued in jenkins.
- User 1 looks at the list of items to QA. Sees a PR for branch b, and looks at it. It's a minor change, but it breaks tests. However, as there has been no notification sent to github, this defaults to the message "This pull request can be automatically merged.". This gets merged, and breaks the build.
With the patch included in #190 - it now will show "Merge with caution!"
When a commit gets pushed to github, it notifies janky, which queues the build. However, Janky doesn't then send a notification that the build is pending until it gets notified that the build has started...
This means that PRs that are still pending in the jenkins queue (rather than being built) show a "This is ok to merge!" because it hasn't any information about it's status.