github / janky

Continuous integration server built on top of Jenkins and Hubot
MIT License
2.76k stars 237 forks source link

Janky doesn't know how to build tags #194

Closed mkantor closed 2 years ago

mkantor commented 10 years ago

This is true for builds triggered by GitHub webhooks and hubot:

mkantor: hubot ci build janky/v0.10.2
hubot: Unknown branch "v0.10.2". Push again

I was surprised by this since I my git experience tells me that annotated tags are just another kind of named ref and should be treated similarly to branches in general.

The particular issue that caused me to realize this was that release tags for a project configured with Janky were not being CI'd. If anything needs to be built/tested, it's releases! I'm able to work around this by telling hubot to hubot ci build project/master immediately after tagging, but this is kind of silly.

Janky also doesn't understand how to build SHAs, which is unfortunate but a bit more understandable. EDIT: It looks like #186 fixed this.