search

github / janky

Continuous integration server built on top of Jenkins and Hubot
MIT License
2.75k stars 213 forks source link

handle strings as room_id everywhere #206

Closed Reprazent closed 10 years ago

Reprazent commented 10 years ago

In https://github.com/github/janky/pull/201 the room id changed from an integer to a string. This was not handled everywhere causing problems implementing janky with hubot on kato

mattr- commented 10 years ago

I could be wrong, but it seems the last two commits are unrelated to making this work properly after the switchover of room_id from an integer to a string. If so, could you remove those commits from the pull request? If not, could you expand on what they're for? Thanks!

Reprazent commented 10 years ago

@mattr- It has been a while. But it seems like these commits where for making sure the janky hubot script posts to a room when it wasn't set when creating the build.

I will move these 2 commits to a separate pull request

Reprazent commented 10 years ago

As it turns out the removed commit should actually use ChatService.default_room I'll rewrite that and rebase #208 when I find some time this week :smiley:

mattr- commented 10 years ago

This looks good. Thanks!