search

github / janky

Continuous integration server built on top of Jenkins and Hubot
MIT License
2.75k stars 213 forks source link

Use path building methods to prevent errors #223

Closed ellneal closed 8 years ago

ellneal commented 8 years ago

I was setting up a janky installation recently and was struggling to work out why it wasn't posting notifications to Hubot. It turned out that it was because I had a trailing slash on the JANKY_HUBOT_URL environment variable, which leads to double slashes in the called URLs (unlike JANKY_BUILDER_DEFAULT, which requires the trailing slash).

I've amended some of the string paths to use path building APIs.

mattr- commented 8 years ago

Great! Thanks for the contribution!