Support Ruby 2.4 - Githubissues

mattr- commented 7 years ago

We should be close to being able to support Ruby 2.4. Here's a list of the following things that I know about needing to be done before we can say we officially support Ruby 2.4:

Upgrade activerecord to version 4.2 at the earlier. Using a 5.x version would be better.
This section of code https://github.com/github/janky/blob/013b416af1307312b313a94ec77c1de2deaf05e8/lib/janky.rb#L56-L60 can be removed
Upgrade any other gems that are known to have incompatibilities with Ruby 2.4

I'd also like to deprecate anything less than Ruby 2.4, so a warning similar to https://github.com/github/janky/blob/013b416af1307312b313a94ec77c1de2deaf05e8/lib/janky.rb#L1-L4 for Ruby 2.3 and below would be great!

cc: @perlun

mattr- commented 6 years ago

The test suite is now running with Ruby 2.4. Need to ensure that the app functions as well.

perlun commented 6 years ago

Sorry, but where did I come into the picture? 😄

mattr- commented 6 years ago

From a comment in another issue :smile: ➡️ https://github.com/github/janky/pull/236#issuecomment-341409318

perlun commented 6 years ago

Ah, thanks! :+1: :smile:

mattr- commented 5 years ago

We're now running on Ruby 2.4 as of current master. :tada:

github / janky

Support Ruby 2.4 #237