search

github / libprojfs

Linux projected filesystem library
GNU Lesser General Public License v2.1
92 stars 14 forks source link

remove unneeded virtualization root setup from VFS API #41

Closed chrisd8088 closed 5 years ago

chrisd8088 commented 5 years ago

We expect any Linux implementation to virtualize using a dedicated mounted filesystem, so we do not need to flag directories within the global file hierarchy as being virtualized. Therefore we can remove the ConvertDirectoryToVirtualizationRoot() function from the VFS API, as this was a legacy from copying the macOS implementation in order to get started on Linux development.

We can also remove the pair of associated error code which pertain to the setup of a virtualization root.

This requires a change to the docker/VFSForGit submodule's commit so we continue to build properly; see also the PR Microsoft/VFSForGit#788.

chrisd8088 commented 5 years ago

@kivikakk -- if you're looking at this later, and think it looks OK, I might nevertheless suggest we don't merge it into our master branch until the Microsoft/VFSForGit#788 PR has been approved and merged upstream. (For one thing, we may end up rebasing github/VFSForGit at that point, which would then change the commit ID in our submodule here, I think.)

kivikakk commented 5 years ago

I might nevertheless suggest we don't merge it into our master branch until the Microsoft/VFSForGit#788 PR has been approved and merged upstream.

👍 👍 Sounds good to me! (And yeah, all looks great 😸)