github / markdownlint-github

An opinionated collection of markdownlint rules used by GitHub.
MIT License
73 stars 0 forks source link

Update and add more test coverage for `no-default-alt-text` #84

Closed khiga8 closed 1 year ago

khiga8 commented 1 year ago

In https://github.com/github/markdownlint-github/pull/83, we refactored the rule so we don't rely entirely on Regex for parsing, which was causing the rule to flag images within code blocks. (Edit: Like https://github.com/github/markdownlint-github/pull/84#issuecomment-1750683661)

This is a follow-up to that change. I noticed the rule was not correctly flagging the case where there are two images like so:

<img alt="image"/><img alt="image" />

This PR makes a few updates:

github-actions[bot] commented 1 year ago

Uh oh! @khiga8, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

github-actions[bot] commented 1 year ago

Uh oh! @khiga8, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

github-actions[bot] commented 1 year ago

Uh oh! @khiga8, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

github-actions[bot] commented 1 year ago

Uh oh! @khiga8, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

github-actions[bot] commented 1 year ago

Uh oh! @khiga8, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

github-actions[bot] commented 1 year ago

Uh oh! @khiga8, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.