github / markup

Determines which markup library to use to render a content file (e.g. README) on GitHub
MIT License
5.83k stars 3.4k forks source link

Fix HTML rendering when there is a line break between backticks #1689

Open shoelzer opened 1 year ago

shoelzer commented 1 year ago

A line break between backticks gets turned into a line break inside a HTML <code> block. This makes browsers render with a line break when that was not intended.

Real world example here: https://github.com/git-lfs/git-lfs/blob/main/docs/man/git-lfs-push.adoc

These lines:

If you are migrating a repository with these commands, make sure to run `git
lfs push` for any additional remote refs that contain Git LFS objects not

Turn into this HTML:

If you are migrating a repository with these commands, make sure to run <code>git
lfs push</code> for any additional remote refs that contain Git LFS objects not
github-actions[bot] commented 1 month ago

Stale issue message

shoelzer commented 1 month ago

This is still an issue. The linked page still renders incorrectly.