search

github / markup

Determines which markup library to use to render a content file (e.g. README) on GitHub
MIT License
5.88k stars 3.4k forks source link

HTML `<blockQuote>`s render further than their content, but MD `>`s do not. #1851

Open RokeJulianLockhart opened 4 months ago

RokeJulianLockhart commented 4 months ago

Errata (Examples)

As an example, in https://github.com/microsoft/debugpy/issues/1645, I have quoted both:

  1. Markdown Quotation Block

    /home/RokeJulianLockhart/Documents/  [-]  `{title: "test_title",  id: "test_data"}`{.JSON5}.dir

    ...(whose markup is undermentioned):

    > ```txt
> /home/RokeJulianLockhart/Documents/  [-]  `{title: "test_title",  id: "test_data"}`{.JSON5}.dir
> ```

  2. HTML Quotation Block

    ...and the undermentioned:

    ```log RokeJulianLockhart@sayw4i:~/Documents/ [-] `{title: "test_title", id: "test_data"}`{.JSON5}.dir$ /usr/bin/env /usr/bin/python3 /home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/adapter/../../debugpy/launcher 33439 -- /home/RokeJulianLockhart/Documents/\ \ \[-\]\ \`\{title\:\ \"test_title\"\,\ id\:\ \"test_data\"\}\`\{.JSON5\}.dir/\`\{title:\ \"test_title\",id:\ \"test_data\"\}\`\{.JSON5\}.dir/core.py Traceback (most recent call last): File "/usr/lib64/python3.12/runpy.py", line 198, in _run_module_as_main return _run_code(code, main_globals, None, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.12/runpy.py", line 88, in _run_code exec(code, run_globals) File "/home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/adapter/../../debugpy/launcher/../../debugpy/__main__.py", line 39, in cli.main() File "/home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 430, in main run() File "/home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 284, in run_file runpy.run_path(target, run_name="__main__") File "/home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 320, in run_path code, fname = _get_code_from_file(run_name, path_name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 289, in _get_code_from_file with io_open_code(decoded_path) as f: ^^^^^^^^^^^^^^^^^^^^^^^^^^ FileNotFoundError: [Errno 2] No such file or directory: '/home/RokeJulianLockhart/Documents/ [-]\t`{title: "test_title",\tid: "test_data"}`{.JSON5}.dir/`{title: "test_title",id: "test_data"}`{.JSON5}.dir/core.py' RokeJulianLockhart@sayw4i:~/Documents/ [-] `{title: "test_title", id: "test_data"}`{.JSON5}.dir$ ```

    ...(whose markup is undermentioned):

    <blockQuote>

```log
RokeJulianLockhart@sayw4i:~/Documents/  [-]     `{title: "test_title",  id: "test_data"}`{.JSON5}.dir$  /usr/bin/env /usr/bin/python3 /home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/adapter/../../debugpy/launcher 33439 -- /home/RokeJulianLockhart/Documents/\ \ \[-\]\    \`\{title\:\ \"test_title\"\,\  id\:\ \"test_data\"\}\`\{.JSON5\}.dir/\`\{title:\ \"test_title\",id:\ \"test_data\"\}\`\{.JSON5\}.dir/core.py 
Traceback (most recent call last):
  File "/usr/lib64/python3.12/runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "/home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/adapter/../../debugpy/launcher/../../debugpy/__main__.py", line 39, in <module>
    cli.main()
  File "/home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 430, in main
    run()
  File "/home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 284, in run_file
    runpy.run_path(target, run_name="__main__")
  File "/home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 320, in run_path
    code, fname = _get_code_from_file(run_name, path_name)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/RokeJulianLockhart/.vscode-insiders/extensions/ms-python.debugpy-2024.11.2024080201-linux-x64/bundled/libs/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 289, in _get_code_from_file
    with io_open_code(decoded_path) as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/home/RokeJulianLockhart/Documents/  [-]\t`{title: "test_title",\tid: "test_data"}`{.JSON5}.dir/`{title: "test_title",id: "test_data"}`{.JSON5}.dir/core.py'
RokeJulianLockhart@sayw4i:~/Documents/  [-]     `{title: "test_title",  id: "test_data"}`{.JSON5}.dir$
```

</blockQuote>

If you scroll on the latter, you shall see that it renders the blockquote line further than the actual content, as a consequence of the <blockQuote> statement being necessarily defined a line after the fenced code block content. However, this shouldn't occur, not least because it doesn't when defining a block quote using Markdown >s.

Bitmap Depiction

In case it doesn't render like that to you, what I see is undermentioned:

image

Environment

Browser https://fedora.pkgs.org/40/fedora-updates-x86_64/firefox-131.0-2.fc40.x86_64.rpm.html
OS https://download.fedoraproject.org/pub/fedora/linux/releases/40/Spins/x86_64/iso/Fedora-KDE-Live-x86_64-40-1.14.iso
github-actions[bot] commented 2 months ago

Stale issue message

RokeJulianLockhart commented 2 months ago

https://github.com/github/markup/issues/1851#issuecomment-2393560792

@GitHub-Actions, what does that mean?