github / markup

Determines which markup library to use to render a content file (e.g. README) on GitHub
MIT License
5.87k stars 3.39k forks source link

markup: blockquote CSS has inconsistent margins #1876

Open westurner opened 2 months ago

westurner commented 2 months ago

blockquote CSS in Markdown previews and renders has inconsistent margins.

I think this may be a regression, but I don't have any screenshots of it having been working.

/* current CSS* /
.markdown-body p, .markdown-body blockquote, .markdown-body ul, .markdown-body ol, .markdown-body dl, .markdown-body table, .markdown-body pre, .markdown-body details {
  margin-top: 0;
  margin-bottom: var(--base-size-16);
}

Screenshot from 2024-09-10 12-56-05

/* suggested CSS */
.markdown-body p, .markdown-body blockquote, .markdown-body ul, .markdown-body ol, .markdown-body dl, .markdown-body table, .markdown-body pre, .markdown-body details {
  margin-top: var(--base-size-8);
  margin-bottom: var(--base-size-2);
}

Screenshot from 2024-09-10 12-55-47

westurner commented 2 months ago
- thing1
  > blockquote without an li
  - > blockquote with an li
- thing2
  > blockquote without an li
  - a
  - > blockquote with an li
  - b
  - c
westurner commented 2 months ago

Screenshot from 2024-09-10 14-05-55

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

westurner commented 1 week ago

Has this been fixed?

On Sun, Nov 10, 2024, 7:09 AM github-actions[bot] @.***> wrote:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

— Reply to this email directly, view it on GitHub https://github.com/github/markup/issues/1876#issuecomment-2466709478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMNSYYRGJPQ2XMYVG4JYDZ75EGDAVCNFSM6AAAAABN7GN67GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWG4YDSNBXHA . You are receiving this because you authored the thread.Message ID: @.***>