github / maven-plugins

Official GitHub Maven Plugins
MIT License
587 stars 197 forks source link

Allow user to set calls per minute in the RateLimiter #127

Open ctoestreich opened 7 years ago

ctoestreich commented 7 years ago

Allow user to provide a param callsPerMinute via configuration block to allow more calls per minute to github. Without param default is 20. This will address some issues from #90 #17 #28 #88 @jakeswenson @alem0lars @bguerin @kevinsawicki

User can configure the following

            <plugin>
                <groupId>com.github.github</groupId>
                <artifactId>site-maven-plugin</artifactId>
                <version>0.13-SNAPSHOT</version>
                <configuration>
                    <callsPerMinute>1000</callsPerMinute>
                </configuration>
            </plugin>
ctoestreich commented 7 years ago

I tried to unwind all the tab v spaces that I would but there is no code style profile in the project and some of the formatting is a bit unclear like 1 space + 1 Tab for indents in java files. I had a hard time reproducing that format with my current style settings in IntelliJ. :)

bguerin commented 7 years ago

I understand. On projects like this (without formatting settings shared), I just does not automatically format sources with my IDE.

ctoestreich commented 6 years ago

@bguerin Just checking on this as we near the 1yr mark.

bguerin commented 6 years ago

And ? I am not a maintainer of these plugins, I only contributed to them ... I do not have rights to merge ...

ctoestreich commented 6 years ago

Who is a maintainer?

ctoestreich commented 6 years ago

@kevinsawicki