search

github / opensourcefriday

🚲 Contribute to the open source community every Friday
https://opensourcefriday.com
MIT License
1.18k stars 160 forks source link

add italian and bulgarian translation #1270

Closed BlueButterflies closed 4 months ago

BlueButterflies commented 5 months ago

Hi, I added translation in Italian and Bulgarian languages.

Thank you in advance

BlueButterflies commented 5 months ago

Hi everyone I added translation in Italian and Bulgarian languages.

Thank you in advance

BlueButterflies commented 4 months ago

I don't understand where is the problem .

ahpook commented 4 months ago 
/home/runner/work/opensourcefriday/opensourcefriday/vendor/gems/ruby/3.1.0/gems/safe_yaml-1.0.5/lib/safe_yaml/load.rb:143:in `parse': (/home/runner/work/opensourcefriday/opensourcefriday/_data/locales/it.yml): did not find expected key while parsing a block mapping at line 103 column 7 (Psych::SyntaxError)

I ran the file through yamlpp-highlight and found the error. There is an ' in line 105 that makes the parse fail - can you change this to a ʼ (UTF-8 apostrophe)? 


    Will_Norris:
      title: "Open Source su <a href='https://github.com/google'>Google</a>"
      name: "Will Norris"
      message: 'Contribuire a progetti open source continua a essere uno dei progetti più apprezzati dal 20% degli ingegneri di Google. L'open source svolge un ruolo così importante in gran parte di ciò che facciamo, quindi cerchiamo di rendere <a href="https://opensource.google.com/docs/patching/"> il processo</a> il più semplice possibile possibile.'
ahpook commented 4 months ago

A couple of the other message keys also have ' characters that will cause the same problem.

It is because the whole YAML value is wrapped in a single quote message: 'the message here' - but when the content also has a ', YAML thinks the value is closed: message: 'L'open source will only see L , and then start parsing the next key at open. Using a ’ will get around the problem, and will let the embedded URLs parse correctly too.

BlueButterflies commented 4 months ago

I apologize for the delay. I made the requested changes.

ahpook commented 4 months ago

Excellent, looks like all the tests are passing now. Thank you for all this work @BlueButterflies !