search

github / ossar-action

Run multiple open source security static analysis tools without the added complexity with OSSAR (Open Source Static Analysis Runner).
MIT License
94 stars 27 forks source link

Improve tool names in sarif output #23

Open Daverlo opened 3 years ago

Daverlo commented 3 years ago

@davidknise You seem to be the main maintainer of this repo.

Bandit and Gosec are using the name property for outputting a description (Security audit for python by bandit and Golang security checks by gosec).

At Github Code Scanning, we use those names for displaying the tool at the Security page. We added some internal logic for handling these special cases and rename them to the tool name, but we are in the process of cleaning up the code and removing it. We suggest using the name property for outputing the tool name (Bandit, and Gosec), and the fullName or short/longDescription properties for storing the current long name.

davidknise commented 3 years ago

Acknowledged. Those names should be Bandit and gosec, so I will file a bug on in the MSCA CLI and get that deployed.

anaarmas commented 3 years ago

Thank you @davidknise 🙇‍♀️ ! Is that repo open source? If so would you mind sharing a link to that issue so we can keep track of progress without pestering you too much 😅 Otherwise would you mind keeping us posted on progress?

Daverlo commented 3 years ago

@davidknise What's the current status? Could you give us an update please? :)

davidknise commented 3 years ago

@anaarmas, @Daverlo my apologies for the late response,

Is that repo open source?

It is not.

Otherwise would you mind keeping us posted on progress? What's the current status? Could you give us an update please? :)

I thought we had this scheduled and am surprised to see it hasn't been deployed yet. I will follow up today to ensure it's in our pipeline.

anaarmas commented 3 years ago

Hi @davidknise, @massto 👋 Does the above message mean this change has already been deployed and we can close this issue?

anaarmas commented 3 years ago

@davidknise @massto following up on this again - can this issue be closed now?