search

github / pages-gem

A simple Ruby Gem to bootstrap dependencies for setting up and maintaining a local Jekyll environment in sync with GitHub Pages
http://pages.github.com
MIT License
1.82k stars 349 forks source link

Proposal: Add amp-jekyll #355

Closed citrusui closed 7 years ago

citrusui commented 7 years ago

Link to plugin

This plugin enables you to generate AMP versions of your Jekyll posts alongside the normal HTML posts. AMP pages load super fast, especially on older mobile devices.

While it is possible to only write posts in AMP (I've tried), you cannot use your own JavaScript or tags like <form> which aren't supported. Yes, the page may load fast by default, but it loses lots of functionality when using a desktop (hence the name Accelerated Mobile Pages).

LewisLebentz commented 7 years ago

Interested in this plugin too.

benbalter commented 7 years ago

I wouldn't be opposed to adding AMP support, especially if it was automatic and transparent (e.g., just activate the plugin and it works), similar to how Jekyll Feed, Jekyll Sitemap, etc. work.

Regardless of the implementation, we wouldn't be able to consider any plugin without unit and integration tests for the desired behavior.

mbirth commented 7 years ago

Related: https://github.com/jekyll/jekyll/issues/3041

benbalter commented 7 years ago

I wouldn't be opposed to adding AMP support, especially if it was automatic and transparent (e.g., just activate the plugin and it works), similar to how Jekyll Feed, Jekyll Sitemap, etc. work.

Regardless of the implementation, we wouldn't be able to consider any plugin without unit and integration tests for the desired behavior.