search

github / pages-gem

A simple Ruby Gem to bootstrap dependencies for setting up and maintaining a local Jekyll environment in sync with GitHub Pages
http://pages.github.com
MIT License
1.82k stars 350 forks source link

build: don't ignore Gemfile.lock for deterministic builds #829

Closed dijonkitchen closed 8 months ago

dijonkitchen commented 2 years ago

Reference: https://bundler.io/rationale.html#checking-your-code-into-version-control

Seems to match what is published: https://pages.github.com/versions/

fulldecent commented 12 months ago

This PR seems to make a failed assertion.

When GitHub Pages builds a website (not talking about GitHub Actions) it does NOT use the Gemfile.lock to find what versions to build with.

It means that GitHub Pages' infrastructure decides which versions of Jekyll/Ruby/... it is running, not you.

This PR does not change that behavior of how GitHub Pages infrastructure works.

So if this is PR is accepted, then the test suite will run against new versions of Jekyll/Ruby/... rather than the version that production uses.

If my understand is correct here, we should NOT merge this PR.

parkr commented 12 months ago

RubyGems do not ship with their Gemfile.lock files. The guidance you linked to is for end users. There is no way for an end user to use the Gemfile.lock from a RubyGem.