search

github / pages-gem

A simple Ruby Gem to bootstrap dependencies for setting up and maintaining a local Jekyll environment in sync with GitHub Pages
http://pages.github.com
MIT License
1.83k stars 353 forks source link

build: update liquid to 4.0.4 #860

Closed gradybarrett closed 1 year ago

gradybarrett commented 1 year ago

Ruby 3.2 removed the "tainted" interface, which liquid <=4.0.3 still uses. Liquid 4.0.4 removes references to this interface so that it works with Ruby 3.2.

Closes https://github.com/github/pages-gem/issues/859.

gradybarrett commented 1 year ago

@parkr hopefully this PR wasn't presumptuous. 😄

parkr commented 1 year ago

Nope! I can't merge this though since I don't work at GitHub anymore. Perhaps @yoannchaudet can help! This patched version fixes compatibility with Ruby 3.2.

adhibsyed commented 1 year ago

Would be great to have this merged.

keithrbennett commented 1 year ago

This issue is blocking the use of Ruby 3.2 for Github Pages sites. Could someone with the authority to merge it please take a look at it? It's a simple one-line fix. I can corroborate that tests pass with this change.

gradybarrett commented 1 year ago

Updated the branch and fixed my gpg config.

vhxs commented 1 year ago

+1 please merge this in, I've had to explicitly point my blog towards this forked repo

JonathanCopeland commented 1 year ago

Can confirm this is still a problem, I'm receiving: Liquid Exception: undefined method `tainted?' for ...

Any ETA on when this will be merged?

yoannchaudet commented 1 year ago

Surfacing that to the team, we will look at it shortly and make a round of update.

parkr commented 1 year ago

@yoannchaudet I'm making a bug patch release of Jekyll soon that allows y'all to also upgrade i18n and tzinfo, if you want to bundle this patch release into your round of updates: https://github.com/jekyll/jekyll/pull/9282

surelynottrue commented 1 year ago

Is there any solution in place for this? This error is not allowing me to push any changes to my Jekyll website :)

JonathanCopeland commented 1 year ago

Same

parkr commented 1 year ago

Hopefully you upgrade the Ruby used by your Jekyll site independently from other apps you maintain! I personally always run CI with any ruby or gem updates before merging. Then I can still push updates to my site while I wait for the update to be compatible. I recommend rbenv for maintaining several different Ruby versions on the same system.

JonathanCopeland commented 1 year ago

Hey everyone, I'm probably missing something, but after running bundle update github-pages I'm still getting the tainted error. Is there anything else that I need to do to serve my site locally?

yoannchaudet commented 1 year ago

The gem has not been fully propagated in the systems. It is being updated today. https://pages.github.com/versions/ will report it as soon as it's there.

yoannchaudet commented 1 year ago

We should be good now: https://pages.github.com/versions. Still updating our legacy build infra but build on Actions are already current.

parkr commented 1 year ago

Thank you so much, @yoannchaudet!

JonathanCopeland commented 1 year ago

Working 100%. Thank you very much @yoannchaudet