search

github / pages-gem

A simple Ruby Gem to bootstrap dependencies for setting up and maintaining a local Jekyll environment in sync with GitHub Pages
http://pages.github.com
MIT License
1.82k stars 349 forks source link

Support Ruby 3.2+, fixes #879 #880

Closed fulldecent closed 8 months ago

parkr commented 1 year ago

@yoannchaudet Hey! Would you mind merging this to fix Ruby 3.2 compatibility? Not sure if you have any other plans for Ruby 3.2, but this would at least fix things like #879.

wbreeze commented 10 months ago

To help the reviewer (please merge?): File.exist? exists in [Ruby 2.0.0.][1] File.exists? shows up as deprecated in [Ruby 2.2.0][2]. That is to say that this PR will leave the gem current and backward compatible with Ruby back at least as far as 2.0.0.

[1] https://ruby-doc.com/core-2.0.0/File.html#method-c-exist-3F [2] https://ruby-doc.com/core-2.2.0/File.html#method-c-exist-3F

wbreeze commented 8 months ago

Hey! Cool! Two approvals; so great! What am I missing that GH still blocks having the merge executed?