search

github / pages-gem

A simple Ruby Gem to bootstrap dependencies for setting up and maintaining a local Jekyll environment in sync with GitHub Pages
http://pages.github.com
MIT License
1.82k stars 349 forks source link

Fix obscured gemfile issue #912

Closed mrmanc closed 1 month ago

mrmanc commented 5 months ago

(edited to include just one change per @parkr’s suggestion—see also stacked PR #914)

Fixes #891. jekyll was unable to find the gems which Bundler had installed as part of the Dockerfile because it was finding a Gemfile in the currently working directory (/src/site), which belongs to the site being built. I resolved this by setting an environment variable to tell Bundler where to find the correct Gemfile.

I’m not a Ruby developer, so I might not have done this conventionally. However it seems to work, and it was the minimum change I could make to resolve those issues.

mrmanc commented 5 months ago

Is there anything else that the team need to support this change? Please let me know if there’s anything else I can do to get it merged.

parkr commented 5 months ago

I might recommend separating the addition of the webrick and the modification of the docket files into two separate PRs. Otherwise LGTM.

mrmanc commented 5 months ago

I might recommend separating the addition of the webrick and the modification of the docket files into two separate PRs. Otherwise LGTM.

Thanks—I’ve done as you’ve suggested 😃. I’m guessing you aren’t able to act on this yourself?