Closed mrmanc closed 1 month ago
Is there anything else that the team need to support this change? Please let me know if there’s anything else I can do to get it merged.
I might recommend separating the addition of the webrick and the modification of the docket files into two separate PRs. Otherwise LGTM.
I might recommend separating the addition of the webrick and the modification of the docket files into two separate PRs. Otherwise LGTM.
Thanks—I’ve done as you’ve suggested 😃. I’m guessing you aren’t able to act on this yourself?
(edited to include just one change per @parkr’s suggestion—see also stacked PR #914)
Fixes #891.
jekyll
was unable to find the gems which Bundler had installed as part of theDockerfile
because it was finding aGemfile
in the currently working directory (/src/site
), which belongs to the site being built. I resolved this by setting an environment variable to tell Bundler where to find the correctGemfile
.I’m not a Ruby developer, so I might not have done this conventionally. However it seems to work, and it was the minimum change I could make to resolve those issues.