search

github / pages-gem

A simple Ruby Gem to bootstrap dependencies for setting up and maintaining a local Jekyll environment in sync with GitHub Pages
http://pages.github.com
MIT License
1.83k stars 354 forks source link

Parkr jekyll3.10 #919

Closed yoannchaudet closed 3 months ago

yoannchaudet commented 3 months ago

Same as https://github.com/github/pages-gem/pull/917 but with an additional jekyll-commonmark-ghpages bump.

Also reconsider https://github.com/github/pages-gem/pull/914 by moving webrick to a gemspec dependency.

parkr commented 3 months ago

Might be best to include Webrick in the gem spec directly? The way it is now folks will ask to upgrade it, but if it's in the gemspec directly then you can set it to be ~> X and give users more freedom to upgrade as they wish.

yoannchaudet commented 3 months ago

Instead of in the dependencies like in https://github.com/github/pages-gem/pull/914?

parkr commented 3 months ago

Instead of in the dependencies like in #914?

Yeah, that's what I was thinking. Anything in dependencies.rb is just more to manage without a lot of gain. It also doesn't matter for https://pages.github.com/versions/ since it's not used to build sites.