github / privileged-requester

Privileged Requester Action
MIT License
15 stars 1 forks source link

Sort reviews by ID rather than date so there cannot be a tie. #134

Closed chrisgavin closed 3 months ago

chrisgavin commented 9 months ago

This sorts reviews by ID rather than date. The reason for this is that submission date only has a 1 second granularity, so it's possible (and seems reasonably common) for two reviews to be submitted at the same time. The ID on the other hand is a monotonically increasing counter that is guaranteed to be unique for each review. I'm hoping this is sufficient to fix the action sometimes believing it doesn't need to approve a PR that it actually does.