Duplicate PR Approvals - Githubissues

github / privileged-requester

Privileged Requester Action

MIT License

15 stars 1 forks source link

Duplicate PR Approvals #170

Closed GrantBirki closed 1 month ago

GrantBirki commented 1 month ago

This Action currently has a bug in its logic where it will continue to re-approve PRs even if it currently has an active and valid approval.

Some additional logic should be added into this Action that does the following:

Checks to see if this workflow has previously approved the PR
Check to see if that approval is still valid (i.e. it has not been dismissed)
If it is approved, and still valid, exit without leaving an additional pull request

Example:

GrantBirki commented 1 month ago

Never mind, this is a documented and known issue 🤦