search

github / proto-gen-go

A 'go generate' script to generate Go files from .proto interfaces
22 stars 7 forks source link

Embed the Dockerfile #4

Closed kfcampbell closed 2 years ago

kfcampbell commented 2 years ago

While looking at #3 I felt like we had an opportunity to retain typing/syntax help from our editors for our Dockerfile if we used Go's embed package. This PR does so!

kfcampbell commented 2 years ago

I like the idea of being able to build the Dockerfile locally to use/test without running the entire Go program.

I understand the "visible at a glance" argument though, and I'll defer to your judgement.

adonovan commented 2 years ago

I like the idea of being able to build the Dockerfile locally to use/test without running the entire Go program.

OK, that's a reason. LGTM.