search

github / rally

GitHub <> Rally integration
MIT License
123 stars 33 forks source link

multiple commit messages #161

Closed vader2890 closed 3 years ago

vader2890 commented 4 years ago

Your issue may already be reported! Please search on the issue tracker before creating one.

Describe the bug If a pull request has multiple commits/commit messages , the check fails to run

To Reproduce Steps to reproduce the behavior:

  1. Create a PR
  2. rally.yml must have the commit message validation checked
  3. Click on the checks
  4. Checks does not run when PR has multiple commit messages

Expected behavior Checks must be run for all commit messages

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

primetheus commented 4 years ago

@vader2890 thanks for opening this up! I'll work on reproducing it and get a fix out shortly 🙇🏽

forevergenin commented 3 years ago

This bug is seen when the PR is updated with additional commits after the initial commit.

Steps to reproduce issue.

  1. Create a PR with one commit and invalid commit id in commit message/description/pr title
  2. The PR checks will fail because of invalid/missing rally information
  3. Update the PR with additional commit messages - new commit messages shouldn't have valid user story id.

After the step 3 expected behavior is to have trigger check and mark it as failed but the the current behavior is PR is marked as ready for merge and the previous checks are resolved.