search

github / rally

GitHub <> Rally integration
MIT License
123 stars 33 forks source link

Reg-ex issue with "S3" #224

Closed einanli closed 3 years ago

einanli commented 3 years ago

Your issue may already be reported! Please search on the issue tracker before creating one.

Describe the bug Having a PR title such as "USXXXX: fix S3 bucket" Results in "S3" getting identified as a Rally User Story.

To Reproduce Steps to reproduce the behavior:

  1. Create a new PR with the title "USXXXX: fix S3 bucket"
  2. See the integration result

Expected behavior Regex to ignore "S3"

Screenshots Please see the screenshot.

Additional context We have a basic config file, checks the PR titles.

primetheus commented 3 years ago

@nab-emre-inanli it looks like this is due to it being a valid Rally artifact type. https://github.com/github/rally/blob/main/lib/RallyValidate.js#L824 is where it's defined, and it could exist in RallyDev as S3... can you try commenting that out and see if it solves the issue for you?

einanli commented 3 years ago

@primetheus, thank you very much for the explanation.