add test cases for superfluous days

github / relative-time-element

Web component extensions to the standard <time> element.

https://github.github.io/relative-time-element/examples/

MIT License

3.57k stars 170 forks source link

add test cases for superfluous days #263

Open TymekDev opened 1 year ago

TymekDev commented 1 year ago

This PR adds cases for whole years and whole months to not have extra days, e.g. May (2023-05-11T00:00:00.00) to July (2023-07-11T00:00:00.00) being 2 months instead of current 2 months, 1 day.

Related issue: #262

primer-css commented 1 year ago

:wave: Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

:art: If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
:fast_forward: If this is a PR that includes changes to an interaction, please include a video recording in the description.
:warning: If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

lukasoppermann commented 1 year ago

I'd love for @keithamus to approve this as he is working on it. Fine from primer FR side

keithamus commented 1 year ago

Thanks, I'm looking into fixing this but I have higher priorities for now. A fix will come though!