search

github / safe-settings

ISC License
599 stars 146 forks source link

Fix Lambda/Serverless Cron #582

Closed benbridts closed 7 months ago

benbridts commented 8 months ago

This fixes a bug introduced by changing module.exports in index.js (commit 1540810)

In https://github.com/github/safe-settings/commit/15408100d15ac18d2698ac2e3bd901b6ba5545db the following change happend in index.js (and that broke the cron/scheduler handler):

- module.exports = (robot, _, Settings = require('./lib/settings')) => {
+ module.exports = (robot, { getRouter }, Settings = require('./lib/settings')) => {
benbridts commented 7 months ago

@decyjphr : sorry for the tag, but I couldn't find the best way to get this PR discussed. Is this a change you would consider merging?

benbridts commented 7 months ago

❤️