Open pydolan opened 4 months ago
I realized that my initial version of full-sync did not return a non-zero exit code when errors occurred, so I updated it to check settings.errors
. I didn't see a way to check the errors from my syncInstallation call, so I modified Settings.syncAll
to return its settings
object.
If someone has a cleaner option for this error checking, please let me know
We could look into using checks to communicate errors back to the Actions workflow.
Yea, tying into Checks would make things cleaner. I'm not familiar with the feature or code in detail, so if anyone has tips/suggestions, let me know.
The other question I had was if the probot gha adapter would help with error collecting, but it doesn't look like the Settings class is sending probot error info, so maybe it wouldn't help
Summary:
This is a potential way of addressing #378 and #379.
As noted on #378, I'm using this along with the following for triggering safe-settings via GHA:
Additional comments:
syncInstallation
using index.js/package.json, I'm happy to change this.settings.errors
. I didn't see a way to check the errors from my syncInstallation call, so I modifiedSettings.syncAll
to return itssettings
object. If someone has a cleaner option for this error checking, please let me know.