Cannot it run in from Docker but works on commad line

github / safe-settings

ISC License

599 stars 146 forks source link

Cannot it run in from Docker but works on commad line #608

Closed agustincelentano closed 6 months ago

agustincelentano commented 6 months ago

Hi,

I am using this successfully by running the node command (I configured all as said)

npm start

When building the docker image and running it says it's listening to localhost:3000 but it does not receive anything from smee.io webhook. I did not touch any template standard provided in the repository for the docker-compose or dockerfile files

From docker

From command line

You can see that the last one receives the responses

What am I doing wrong here?

svg153 commented 6 months ago

Hi.

I think it works as expected according to these two lines... smee client is only for development:

smee-client dep in in devDependencies in package.json: https://github.com/github/safe-settings/blob/90ae0ae4f686dc584495b0aa9caa4061db8970e6/package.json#L52
In the Dockerfile, the NODE_ENV is set to production: https://github.com/github/safe-settings/blob/90ae0ae4f686dc584495b0aa9caa4061db8970e6/Dockerfile#L3

Solutions:

Try to change the NODE_EMV in Dockerfile
Use ngrok in your local machine to connect with safe-settings in Docker. See my testing org: https://github.com/svg153-org/admin/blob/main/apps/safe-settings-local/README.md#start

agustincelentano commented 6 months ago

It worked changed to use the devDepedencies when running docker locally. Thanks!