We started hitting issues like github+safe-settings+6c297f2fdb1f5e00704b60a4e74093ea566170a6/node_modules/safe-settings/lib/settings.js:17:7)","type":"Error","msg":"Cannot read properties of undefined (reading 'indexOf')
Turns out its because not all new MergeDeep's pass ignorable fields, so lets allow ignoreableFields to default to [].
Additionally fixes up some tests which werent correctly passing ignorable fields
We started hitting issues like
github+safe-settings+6c297f2fdb1f5e00704b60a4e74093ea566170a6/node_modules/safe-settings/lib/settings.js:17:7)","type":"Error","msg":"Cannot read properties of undefined (reading 'indexOf')
Turns out its because not all new MergeDeep's pass ignorable fields, so lets allow ignoreableFields to default to
[]
.Additionally fixes up some tests which werent correctly passing ignorable fields