github / safe-settings

ISC License
561 stars 137 forks source link

import eta templates as javascript strings #648

Closed Oatelaus closed 2 days ago

Oatelaus commented 1 week ago

This pull request aims to move away from importing eta templates using the file system location and instead rely on the node module resolution system, passing the template as a string.

The underlying reason for this change is because the current implementation will break bundled deployments which are fairly common within a serverless deployment and I cannot see negatives to non-bundled users of this package.

decyjphr commented 2 days ago

Awesome! Thanks @Oatelaus