On merging the PR, no configuration settings are updated, but the main branch check shows:
What is the expected behavior
The configuration changes should be applied when the PR is merged.
I would also assume the PR comment wouldn't show the full config object under Additions for subsequent config changes, instead should show either the new configuration only under Additions, or show the changes under Modifications
Problem Description
Repo creation is working, but no configuration is being applied.
What is actually happening
The initial state is as follows:
deployment-settings.yml:
.github/settings.yml
N.B. I initially tried with an empty
settings.yml
, but thought I might have to provide some basic config for things to work properly..github/repos/miles-new-test.yml
the
miles-new-test
repository was successfully created, is private, and had an init commit, but I was not added as an admin.In a subsequent PR I made the following change:
.github/repos/miles-new-test.yml
The PR comment shows:
and the PR check shows:
On merging the PR, no configuration settings are updated, but the
main
branch check shows:What is the expected behavior
The configuration changes should be applied when the PR is merged.
I would also assume the PR comment wouldn't show the full config object under Additions for subsequent config changes, instead should show either the new configuration only under Additions, or show the changes under Modifications
Based on the screenshots in https://github.com/github/safe-settings?tab=readme-ov-file#pull-request-workflow, I'd also expect the PR check output to have a Collaborators Settings column with a 🖐️.
Error output, if available
Here's the
trace
logging from that time period: safe-settings.jsonl.logI can't see any obvious errors in the logs, though there a few cases where the word
undefined
or things like[object Object]
appear in log messages.Context
Are you using the hosted instance of probot/settings or running your own?
Running our own, in kubernetes via the Helm chart provided.
If running your own instance, are you using it with github.com or GitHub Enterprise?
github.com (Team plan)
Version of probot/settings
ghcr.io/github/safe-settings:2.1.11
Version of GitHub Enterprise
N/A
Github App Permissions/Events