search

github / scientist

:microscope: A Ruby library for carefully refactoring critical paths.
MIT License
7.47k stars 442 forks source link

Update README, remove exception handling ambiguity #110

Closed mriddle closed 4 years ago

mriddle commented 4 years ago

When reading the documentation and implementing an experiment I was caught out by the contradictory information.

The following changes aim to remove any confusion, one must override the method if they expect exceptions to be swallowed.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.003%) to 99.112% when pulling 396e1e546b73a7ab8b529f64152ea900af52e3fa on mriddle:add-exception-handling-note into e4bd860ddf47f5e38c0e9fb166267cbfd58eb030 on github:master.

rick commented 4 years ago

I think this is an improvement. @zerowidth?