search

github / scientist

:microscope: A Ruby library for carefully refactoring critical paths.
MIT License
7.44k stars 439 forks source link

CI: Add Ruby 2.7 and 3.0 to the matrix, drop EOL Ruby versions #150

Closed olleolleolle closed 3 years ago

olleolleolle commented 3 years ago

This PR adds Ruby versions 2.7 and 3.0 to the CI matrix.

In addition, the version numbers for the matrix are now updated to the latest patch versions.

Source for the version numbers known by rvm: https://github.com/rvm/rvm/blob/master/config/known#L12

Suggestion: Perhaps fewer versions can be in here? Update: Dropped EOL Ruby versions, too.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.6%) to 99.713% when pulling 93d8210b079f29214383b8e191ee094123649cec on olleolleolle:patch-1 into 303c1f4ff98786b702507ed0c4f8cfdeb5fc7138 on github:master.

olleolleolle commented 3 years ago

@zerowidth 👋 Thanks for the swift reply, here's a narrower matrix for you.

olleolleolle commented 3 years ago

@zerowidth A follow-up - since the code is now still compatible with 2.3, but not tested on it, it's perhaps not time to drop anything from the gemspec, like required_ruby_version sits at "Ruby 2.3+", which I guess is fine. No action needed.

zerowidth commented 3 years ago

Right on, thank you! I agree that 2.3+ in the gemspec is fine even if it's not tested that far back anymore.