issues
search
github
/
scientist
:microscope: A Ruby library for carefully refactoring critical paths.
MIT License
7.44k
stars
439
forks
source link
Fix example code in README
#190
Closed
tricknotes
closed
4 months ago
tricknotes
commented
1 year ago
A method that has
?
suffix should return boolean, but this method return an object that respond to
valid?
.
All other examples don't have
?
.
https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L44
https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L152
https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L167
https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L251
https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L498
https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L553
?
suffix should return boolean, but this method return an object that respond tovalid?
.?
.