Handle different schemes in dedup logic - Githubissues

github / secure_headers

Manages application of security headers with many safe defaults

MIT License

3.16k stars 252 forks source link

Handle different schemes in dedup logic #484

Closed srt32 closed 2 years ago

srt32 commented 2 years ago

closes https://github.com/github/secure_headers/issues/317

All PRs:

[X] Has tests
[ ] Documentation updated - should anything be updated?

Adding a new header

Generally, adding a new header is always OK.

Is the header supported by any user agent? If so, which?
What does it do?
What are the valid values for the header?
Where does the specification live?

Adding a new CSP directive

Is the directive supported by any user agent? If so, which?
What does it do?
What are the valid values for the directive?

Some questions

Does this change follow the spec?
Is URI.parse okay? Could it raise? Is there a more performant way to do this?

srt32 commented 2 years ago

https://github.com/github/secure_headers/pull/478 beat me to it!