search

github / semantic

Parsing, analyzing, and comparing source code across many languages
8.97k stars 452 forks source link

Remove the install via homebrew from the bootstrap? #628

Closed philderbeast closed 4 years ago

philderbeast commented 4 years ago

I see from their docs that the binary installer is the recommended way to install bazel on mac.

https://docs.bazel.build/versions/master/install-os-x.html

Would it be possible to remove the install via homebrew from the bootstrap?

https://github.com/github/semantic/blob/aca39e86683cf09071fc884313d7ec676f4c2c4b/script/bootstrap-bazel#L6

patrickt commented 4 years ago

At GitHub, the convention for software installed through script/bootstrap scripts is to use Homebrew. Nothing in the documentation or the Homebrew formula suggests to me that there’s a substantiative difference between the options, and said formula seems like it’s up to date, so I think it’s most appropriate to stick to our conventions here.

philderbeast commented 4 years ago

I was unaware of the github convention. Good to know. Thanks for the explanation.