search

github / semantic

Parsing, analyzing, and comparing source code across many languages
8.98k stars 452 forks source link

Demo prep #685

Closed robrix closed 2 years ago

robrix commented 2 years ago

This PR fixes up a bunch of stuff for the exception tracing analysis and corresponding demo.

robrix commented 2 years ago

@patrickt: for whatever reason I can't reply to https://github.com/github/semantic/pull/685#discussion_r910214150 (re: using Builder instead of constructing Text by <>) directly. This is both debug and demo code, and is run over small programs (pretty much by necessity since we don't support most of Python yet), so I'm comfortable leaving it in the direct-but-stupid mode… for now.

Given that this is my response to a few of the above (excellent!) comments, I think it's worth making explicit that we haven't yet decided if this is going to become more than a hacked-up prototype, i.e. whether we're going to put any more engineering effort into it. If we are, this definitely deserves a follow-up PR resolving all of these, but if not it'd be wasted time—except insofar as future prototypes might develop further; but we can resolve these issues at that point.

Lazy evaluation, in other words 😅

robrix commented 2 years ago

Did the OverloadedStrings thing; re-review would be greatly appreciated! ❤️